-
Notifications
You must be signed in to change notification settings - Fork 186
feat: add entitlement/app subscription support #1617
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Merged
FayeDel
merged 11 commits into
interactions-py:unstable
from
AstreaTSS:entitlement-support
Mar 11, 2024
Merged
feat: add entitlement/app subscription support #1617
FayeDel
merged 11 commits into
interactions-py:unstable
from
AstreaTSS:entitlement-support
Mar 11, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Untested as the only bot that I have that uses entitlements is in production, and can't be used for testing.
…teractions-py-library into entitlement-support
Turns out, there's a number of cases where it's impossible to know which entitlement you're dealing with.
Thanks to @Wolfhound905, I was able to test it and fix a few bugs. This should be ready for review. |
silasary
approved these changes
Feb 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test, but this looks good to me
LGTM, as far as I can see and test to a degree, merging 👍🏻 |
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Adds support for entitlements, otherwise known as App Subscriptions, into
interactions.py
.Changes
Entitlement
object.send_premium_required
toInteractionContext
. I'm unsure of the naming here, but I can't think of another good name to use.entitlements
as an attribute toBaseInteractionContext
.Client
to allow normal users to use them.Related Issues
Resolves #1613.
Test Scenarios
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files