fix: Handle null reference when Voice State is still in cache, but the channel it belongs to has been expired #1648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
If you have a particularly small expiry for the channel cache, or someone stays in a Voice Channel for a particularly long time, you can end up with a situation where the Voice State is cached, but the associated channel is not.
This leads to a fun null reference exception when the user eventually does leave the channel.
Changes
Adds a check that state.channel is not None.
Related Issues
Fixes #1644
Test Scenarios
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files