feat/fix: improve typehinting of wait_fors #1694
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This PR improves typehintings for the
wait_for
functions, largely by using plenty of overloads. It also fixes some incorrect typehints along the way.Changes
wait_for
, makeevent: Union[str, "BaseEvent"]
>event: Union[str, "type[BaseEvent]"]
.wait_for
to let the typehinter return the type of event passed in if an event type is passed at any point.wait_for_component
to enforce either passingmessages
orcomponents
.Related Issues
Test Scenarios
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files (I'm facing issues with this check running in certain contexts, I'll let the bot take care of it)