Skip to content

fix: make ClientT covariant #1708

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

AstreaTSS
Copy link
Member

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

This PR makes ClientT covariant. This fixes a couple of typehinting issues I noticed, and... well, it makes sense for it to be covariant anyways, considering what it's meant for.

Changes

See description.

Related Issues

Test Scenarios

import interactions as ipy
from interactions.ext import prefixed_commands as prefixed

class MyBot(ipy.Client):
    pass

class MyContext(prefixed.PrefixedContext[MyBot]):
    pass

@prefixed.prefixed_command()
async def test(ctx: MyContext):
    await ctx.reply("Hi!")

bot = MyBot(...)
prefixed.setup(bot, prefixed_context=MyContext)  # here

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@silasary silasary merged commit 8071e4e into interactions-py:unstable Jun 27, 2024
2 checks passed
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants