fix: remove erroneous pyi file messing up client typehints #1749
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
This PR is the same issue of #1748, but fixes the issue library-wide instead of just for extensions.
To recap: using
client: Client
as a class variable for classes resulted in theclient
being of typeUnknown
to Pyright thanks to a "class cannot derive from itself" issue.Eventually, I narrowed down the issue to
_template.pyi
which madeEventMixinTemplate
, the class used in all processors and so inClient
, inherit fromClient
, causing a self-derivative.The file as a whole was added in 2022, evidentially to make type hinting better when using
EventMixinTemplate
. While it would be nice to keep these typehints, this PR removes thepyi
file instead and adjusts some of the code so that what is currently there is typehinted enough for convenience.Changes
_template.pyi
._template.py
to add attributes toEventMixinTemplate
used in certain places.EventMixinTemplate
.Related Issues
Test Scenarios
Python Compatibility
3.10.x
3.11.x
Checklist
pre-commit
code linter over all edited files