Typed array change proposal #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add test case to check invalid terminator * Fix invalid array termination
* Refine public API Drop Ref suffix * Drop ref suffix from JSFunctionRef
* Support Holes in Array * Use filter(() => true) * Revert accidently changed line
j-f1
reviewed
Sep 9, 2020
| } | ||
| } | ||
|
|
||
| public init(_ object: JSObject) { |
There was a problem hiding this comment.
Does this need to be pubic? I worry that someone would pass a non-TypedArray in.
There was a problem hiding this comment.
I added a failable init instead of this. What do you think about the new one?
j-f1
approved these changes
Sep 10, 2020
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change is d64def7
I want to avoid managing reference count manually.
If you accept my proposal, I can immediately merge your PR swiftwasm#31