Skip to content

Typed array change proposal #1

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 12 commits into from
Sep 10, 2020
Merged

Typed array change proposal #1

merged 12 commits into from
Sep 10, 2020

Conversation

kateinoigakukun
Copy link

@kateinoigakukun kateinoigakukun commented Sep 9, 2020

The main change is d64def7

I want to avoid managing reference count manually.

If you accept my proposal, I can immediately merge your PR swiftwasm#31

Copy link
Owner

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM

}
}

public init(_ object: JSObject) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be pubic? I worry that someone would pass a non-TypedArray in.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a failable init instead of this. What do you think about the new one?

@j-f1 j-f1 merged commit 2370a1f into j-f1:typed-array Sep 10, 2020
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants