-
Notifications
You must be signed in to change notification settings - Fork 0
Typed array change proposal #1
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Typed array change proposal #1
Conversation
* Add test case to check invalid terminator * Fix invalid array termination
* Refine public API Drop Ref suffix * Drop ref suffix from JSFunctionRef
* Support Holes in Array * Use filter(() => true) * Revert accidently changed line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise LGTM
} | ||
} | ||
|
||
public init(_ object: JSObject) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be pubic? I worry that someone would pass a non-TypedArray in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a failable init instead of this. What do you think about the new one?
The main change is d64def7
I want to avoid managing reference count manually.
If you accept my proposal, I can immediately merge your PR swiftwasm#31