Skip to content

Font Awesome 5 support #126

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Closed
jakezatecky opened this issue Jan 27, 2019 · 0 comments
Closed

Font Awesome 5 support #126

jakezatecky opened this issue Jan 27, 2019 · 0 comments
Milestone

Comments

@jakezatecky
Copy link
Owner

Currently this component largely makes use of Font Awesome 4 icons (assuming a developer has not opted to use the icons property). While the same set of icons are generally available in Font Awesome 5 Free, some of their Unicode values have changed and there is a delineation between "regular" and "solid" styles of each icon.

The upgrade path is relatively straightforward, but we likely want to continue to support the old Font Awesome 4 style. Due to backward compatibility considerations, we would want to default to the older FA4 while providing an easy way to using FA5.

This could be through the use of a property like iconsClass, which could be set to 'fa5'.

On the v2.0 release, it might make sense to make Font Awesome 5 the default.

@jakezatecky jakezatecky added this to the v1.5.0 milestone Jan 27, 2019
jakezatecky added a commit that referenced this issue Jan 27, 2019
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant