Skip to content

Poor performance on large number of nodes #14

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Closed
jakezatecky opened this issue Oct 12, 2016 · 4 comments
Closed

Poor performance on large number of nodes #14

jakezatecky opened this issue Oct 12, 2016 · 4 comments

Comments

@jakezatecky
Copy link
Owner

The tree suffers from poor performance when checking a parent with many nodes. Since those nodes are not necessarily rendered when collapsed, this should not be the case. Likely will be improved with stateless conversion (#12).

@jakezatecky jakezatecky added this to the v0.3.0 milestone Oct 12, 2016
@jakezatecky
Copy link
Owner Author

Although some recent improvements were made, the performance is still kind of bad on large number of nodes.

jakezatecky added a commit that referenced this issue Oct 20, 2016
@jakezatecky jakezatecky modified the milestones: v0.3.1, v0.3.0 Jan 14, 2017
@jakezatecky jakezatecky removed this from the v0.4.0 milestone Jan 27, 2017
@SirGordon
Copy link

SirGordon commented Apr 5, 2017

@jakezatecky
Copy link
Owner Author

@SirGordon I am not sure if that applies, as the performance bottleneck here is not on the rendered components per se, but on the computations it takes to traverse children on check state updates and retrievals.

jakezatecky added a commit that referenced this issue Apr 25, 2017
jakezatecky added a commit that referenced this issue Apr 25, 2017
@jakezatecky
Copy link
Owner Author

This issue was caused by O(n*n) performance, due to iterating through the checked and expanded arrays for each node. A more optimized version exists that flattens the nodes array and each node now checks against its mapped value.

No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants