-
Notifications
You must be signed in to change notification settings - Fork 214
Poor performance on large number of nodes #14
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Comments
Although some recent improvements were made, the performance is still kind of bad on large number of nodes. |
planning to use https://github.com/bvaughn/react-virtualized? |
@SirGordon I am not sure if that applies, as the performance bottleneck here is not on the rendered components per se, but on the computations it takes to traverse children on check state updates and retrievals. |
This issue was caused by O(n*n) performance, due to iterating through the |
The tree suffers from poor performance when checking a parent with many nodes. Since those nodes are not necessarily rendered when collapsed, this should not be the case. Likely will be improved with stateless conversion (#12).
The text was updated successfully, but these errors were encountered: