Skip to content

can not find a way to display Empty Folder. #171

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Closed
ANANDKNIT opened this issue Oct 11, 2019 · 1 comment · Fixed by #177
Closed

can not find a way to display Empty Folder. #171

ANANDKNIT opened this issue Oct 11, 2019 · 1 comment · Fixed by #177
Labels
enhancement
Milestone
v1.6.0

Comments

@ANANDKNIT
Copy link

I want to render Empty Folders in this tree.
Selection_001
Instead of folder icon I am getting file icon
GuyPaddock pushed a commit to GuyPaddock/react-checkbox-tree that referenced this issue Nov 24, 2019
[jakezatecky#171] Allow Parent Nodes to Have an Empty children Array
fd06dce 
In computer science terms, a node without any children is a "leaf". But
in practical use, it's common to run into structures (e.g. empty folders
in file systems) where a node is still a parent because it does not
_yet_ have children but has the capacity to have children in the future.

Closes jakezatecky#171.
@GuyPaddock GuyPaddock mentioned this issue Nov 24, 2019
Merged
@GuyPaddock
Copy link
Contributor

Just submitted a PR for this issue; ran into it myself.

As a workaround, I think it's possible to ensure that "empty" nodes have at least one child that just has a label of "Empty folder" with showCheckbox set to false.

@jakezatecky jakezatecky added this to the v1.6.0 milestone Nov 26, 2019
jakezatecky pushed a commit that referenced this issue Nov 26, 2019
@GuyPaddock @jakezatecky
[#171] Allow Parent Nodes to Have an Empty children Array (#177)
7c38686 
In computer science terms, a node without any children is a "leaf". But
in practical use, it's common to run into structures (e.g. empty folders
in file systems) where a node is still a parent because it does not
_yet_ have children but has the capacity to have children in the future.

Closes #171.
@thehig thehig mentioned this issue Jan 21, 2020
Open
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

#171 - Allow Parent Nodes to Have an Empty children Array GuyPaddock/react-checkbox-tree
3 participants
@GuyPaddock @jakezatecky @ANANDKNIT