Skip to content

Remove Moq usage #1338

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Remove Moq usage #1338

merged 2 commits into from
Sep 19, 2023

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Sep 19, 2023

Remove usage of Moq in tests, due to all the commotion around SponsorLink. We had minimal usage, and the rewrite was easy. It's always nice to reduce our set of dependencies.

QUALITY CHECKLIST

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1338 (83b5d00) into master (a3418fe) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
+ Coverage   93.00%   93.03%   +0.02%     
==========================================
  Files         268      268              
  Lines        8793     8795       +2     
==========================================
+ Hits         8178     8182       +4     
+ Misses        615      613       -2     
Files Changed Coverage Δ
.../JsonApiDotNetCore/Middleware/JsonApiMiddleware.cs 97.81% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

@github-actions
Copy link

Qodana for .NET

5 new problems were found

Inspection name Severity Problems
Convert delegate variable into local function ◽️ Notice 5

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@bkoelman bkoelman marked this pull request as ready for review September 19, 2023 12:53
@bkoelman bkoelman merged commit 9e4e9c8 into master Sep 19, 2023
@bkoelman bkoelman deleted the remove-moq-usage branch September 19, 2023 12:54
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant