-
Notifications
You must be signed in to change notification settings - Fork 14.1k
feat: add Maximum number of Parallelism branches to env #15964
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Conversation
Please see this PR feat: env MAX_TOOLS_NUM (#15431). You need to add those files in the docker-compose.yaml as well. And don't forget to link an existing issue or create one. |
Modified as requested, thanks |
dify/web/app/components/workflow/constants.ts Line 419 in 2c17bb2
I think you should read the new variable here. |
Sorry, I don't quite understand what you mean, could you explain it in more detail? |
At the moment I don't see the front-end code reading this newly defined variable |
How can I make the maximum parallel limit to 100 for example? I tried different approaches, but nothing helped: |
|
Thanks for the screenshots and clear examples! |
It is working for Loop node, but not for iteration: |
…5964) Co-authored-by: Xiaoba Yu <xb1823725853@gmail.com>
This PR is wrong |
@XiaoBa-Yu if you want to contribute to public project, you have to understand how it works, and you have to test your modifications. The project uses a docker-compose that reads ENVIRONMENT_VARIABLE from the .env file copied from You probably copied code from That value is used in the project web, the project has its own Dockerfile and it is made to read variables from his own .env file Inspecting the file you should notice that all the ENVIRONMENT VARIABLES are prefixed with NEXT_PUBLIC_ To use the ENVIRONMENT VARIABLE value in the typescript code there's a file that reads the value and exports a CONSTANT VARIABLE That CONSTANT VARIABLE is then used in the front-end Typescript files by importing it: By now, you should ask yourself: "how is it possible that the CONSTANT variable in the code reads its value from an ENVIRONMENT variable that has a name DIFFERENT from the one that I change in the docker-compose ??"
@Woo0ood unfortunately forgot this step. With this PR #15964 @SimonPP123 Objected that it was NOT working You have another PR #16805 where you used the correct file to read variable web/app/components/workflow/constants.ts In the other PR #16805 that is after this one, you correctly use: but did not come back to this PR to fix it |
Sorry, I misunderstood your question before.
Sorry, I misunderstood your question. The 'Maximum parallelism' variable of the iteration node currently does not support env settings. The 'Maximum Loop Count' variable of the loop node is set by the NEXT_PUBLIC_LOOP_NODE_MAX_COUNT environment variable. |
Summary
Need to increase the maximum number of parallel branches.
Tip
Resolves #15969.
Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods