Skip to content

Update the model modal:position the scrollbar further inside the modal #17672

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 6 commits into from
Apr 11, 2025

Conversation

maoguy
Copy link
Contributor

@maoguy maoguy commented Apr 9, 2025

fixed the Conflict between the scrollbar and the rounded corners on he right side of the "Model Confighuration Form Modal"

link for the issue👉Fix #17671

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before

image

After

image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Apr 9, 2025
@crazywoola crazywoola requested review from Copilot and iamjoel and removed request for Copilot April 10, 2025 14:10
@crazywoola crazywoola self-assigned this Apr 10, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 11, 2025
@crazywoola crazywoola merged commit 0185f84 into langgenius:main Apr 11, 2025
5 checks passed
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
2 participants