-
Notifications
You must be signed in to change notification settings - Fork 14.1k
support load .env config from nacos #18186
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Conversation
Please fix the tests in CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
api/configs/remote_settings_sources/nacos/utils.py:2
- [nitpick] The use of 'self' as the first parameter in this standalone function is potentially confusing. Consider renaming it to something more appropriate (e.g. 'content_parser' if needed) or refactoring this logic as a static method.
def _parse_config(self, content: str) -> dict[str, str]:
api/configs/remote_settings_sources/nacos/init.py:37
- [nitpick] The log message tag '[get-access-token]' is misleading in the context of the async initialization of the settings source. Consider updating it to reflect that the error occurred during Nacos config fetching.
logger.exception("[get-access-token] exception occurred")
Why hasn't CI been running even after a day has passed? @crazywoola |
Not sure about the CI pipeline, I have closed it and reopen the PR again. |
Summary
support load .env config from nacos
Similar to #11210
Resolved #11064
Tip
Close issue syntax:
Fixes #<issue number>
orResolves #<issue number>
, see documentation for more details.Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods