Skip to content

fix: styles and missing imports #18396

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025
Merged

Conversation

crazywoola
Copy link
Member

Summary

Follow up of the Feat/music annotation (#18391)
Fix the missing deps

import { useEdgesInteractionsWithoutSync } from '@/app/components/workflow/hooks/use-edges-interactions-without-sync'
import { useNodesInteractionsWithoutSync } from '@/app/components/workflow/hooks/use-nodes-interactions-without-sync'

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@crazywoola crazywoola requested review from zxhlyh and Copilot April 19, 2025 06:42
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 19, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes missing dependency imports and adjusts styles for the music markdown block.

  • Replaces useEdgesInteractions and useNodesInteractions with their WithoutSync counterparts in the debug-and-preview panel.
  • Updates abcjs render configuration and removes a fixed minHeight style to improve responsiveness in the music markdown block.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
web/app/components/workflow/panel/debug-and-preview/index.tsx Replaces old interaction hooks with new imports to fix dependency issues.
web/app/components/base/markdown-blocks/music.tsx Updates abcjs render settings and adjusts container styling for responsive design.
Comments suppressed due to low confidence (1)

web/app/components/base/markdown-blocks/music.tsx:29

  • Removing the minHeight style may lead to layout issues if the container doesn’t receive sufficient height; consider restoring a minimum height or verifying the design change.
<div style={{ minWidth: '100%', overflow: 'auto' }}>

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 19, 2025
@crazywoola crazywoola merged commit 93c1ee2 into main Apr 19, 2025
8 checks passed
@crazywoola crazywoola deleted the chore/refine-some-styles-of-md branch April 19, 2025 06:46
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants