Revert "fix: parameter rule" #8070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 900fd82.
dosubot
bot
added
the
size:S
AAEE86
deleted the
revert-8064-fix/8057-bug-spark-series-models-parameter-top_k-should-be-int
branch
AAEE86
restored the
revert-8064-fix/8057-bug-spark-series-models-parameter-top_k-should-be-int
branch
AAEE86
deleted the
revert-8064-fix/8057-bug-spark-series-models-parameter-top_k-should-be-int
branch
cuiks
pushed a commit
to cuiks/dify
that referenced
this pull request
Sep 26, 2024
lau-td
pushed a commit
to heydevs-io/dify
that referenced
this pull request
Oct 23, 2024
idonotknow
pushed a commit
to AceDataCloud/Dify
that referenced
this pull request
Nov 16, 2024
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8064
The official has not modified the range of top_k.
official documentation
The bug I reported is that the step setting in the front end is incorrect. It should be set to step="1".
<input class="shrink-0 block ml-4 pl-3 w-16 h-8 appearance-none outline-none rounded-lg bg-gray-100 text-[13px] text-gra-900" max="6" min="1" step="0.1" type="number" data-tabindex="" tabindex="-1">