chore: apply pep8-naming rules for naming convention #8261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenliang123
force-pushed
the
ruff-n
branch
from
6fe698f to
1e693c9
Compare
dosubot
bot
added
size:L
|
All the suggested changes are made and checked manually, which are also tracable in each commits. |
bowenliang123
changed the title
bowenliang123
changed the title
laipz8200
requested changes
Sep 11, 2024
api/core/model_runtime/model_providers/volcengine_maas/legacy/volc_sdk/__init__.py
Outdated
Show resolved
Hide resolved
laipz8200
requested changes
Sep 11, 2024
bowenliang123
commented
Sep 11, 2024
|
Thanks ! |
ZhouhaoJiang
added a commit
that referenced
this pull request
Sep 12, 2024
* main: (141 commits) fix(workflow/hooks/use-shortcuts): resolve issue of copy shortcut not working in workflow debug and preview panel (#8249) chore: cleanup pycodestyle E rules (#8269) let claude models in bedrock support the response_format parameter (#8220) enhance: improve empty data display for detail panel (#8266) chore: remove useless code (#8198) chore: apply pep8-naming rules for naming convention (#8261) fix:ollama text embedding 500 error (#8252) Update Gitlab query field, add query by path (#8244) editor can also create api key (#8214) fix: upload img icon mis-align in the chat input area (#8263) fix: truthy value (#8208) fix(workflow): IF-ELSE nodes connected to the same subsequent node cause execution to stop (#8247) fix: workflow parallel limit in ifelse node (#8242) fix: CHECK_UPDATE_URL comment (#8235) fix:error when adding the ollama embedding model (#8236) fix: improving the regionalization of translation (#8231) feat: add from_variable_selector for stream chunk / message event (#8228) fix(workflow): answers are output simultaneously across different braches in the question classifier node. (#8225) fix(workflow): in multi-parallel execution with multiple conditional branches (#8221) fix(docker/docker-compose.yaml): Set default value for `REDIS_SENTINEL_SOCKET_TIMEOUT` and `CELERY_SENTINEL_SOCKET_TIMEOUT` (#8218) ...
ZhouhaoJiang
added a commit
that referenced
this pull request
Sep 12, 2024
* feat/new-login: fix: N817 CamelCase ElementTree imported as acronym ET fix: lint error fix(workflow/hooks/use-shortcuts): resolve issue of copy shortcut not working in workflow debug and preview panel (#8249) chore: cleanup pycodestyle E rules (#8269) let claude models in bedrock support the response_format parameter (#8220) enhance: improve empty data display for detail panel (#8266) chore: remove useless code (#8198) chore: apply pep8-naming rules for naming convention (#8261) fix:ollama text embedding 500 error (#8252) Update Gitlab query field, add query by path (#8244) editor can also create api key (#8214) fix: upload img icon mis-align in the chat input area (#8263) fix: truthy value (#8208)
cuiks
pushed a commit
to cuiks/dify
that referenced
this pull request
Sep 26, 2024
lau-td
pushed a commit
to heydevs-io/dify
that referenced
this pull request
Oct 23, 2024
idonotknow
pushed a commit
to AceDataCloud/Dify
that referenced
this pull request
Nov 16, 2024
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsDescription
apply the Ruff's pep8-naming rules
N: https://docs.astral.sh/ruff/rules/#pep8-naming-npep8-naming rules benefits in alignments to PEP8 with:
@classmethod@staticmethoddecorators along with their first argument (N804 rule)@classmethodis placed after@model_validatorand@field_validatoras suggested by Pydantic docs... The first argument should be cls (and we also recommend you use @classmethod below @model_validator for proper type checking), ...(https://docs.pydantic.dev/latest/concepts/validators/#model-validators)add new globally exclude rules:
en_USstyle available in classes.Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration