Refactor plugin to respond to init request and propagate errors to Lapce #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbina
changed the title
1. Respond to the initialization request with InitializeResult::default(). 2. Bubble up error to Lapce except when using `host_sucess`, `host_error` and `start_lsp` because if they fail then there's not much that can be done. A better way to deal with issues in plugins is for Lapce to be aware of it but this should work for now. Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
hbina
force-pushed
the
hbina-refactor-to-latest-lib
branch
from
9963379 to
5189416
Compare
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR assumes this other PR gets merged lapce/lapce-plugin-rust#18