Skip to content

Docs Update: Tutorials #9

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AadityaRajPaudel
Copy link

Addition of extra content for 'cons' function, and addition of definition of 'getf' function in Plists.

@AadityaRajPaudel
Copy link
Author

Due to relative changes in the positions of texts after addition of extra contents in the tutorial.md file, changes are shown in many lines of code, but there are only 2 major points at which the changes are made, as mentioned in the two commits.

@daninus14
Copy link
Collaborator

daninus14 commented Feb 25, 2025

Regarding the second commit: the formatting changes make it really hard to follow. I'm not opposed to the formatting changes, but it would make it much easier to understand if you had those in a separate commit. Can you undo that commit and split it into two?

Regarding the first commit: 3c4462d Unclear why you are using a defun over there, and it doesn't look correct either. Perhaps using an english sentence would be easier? You are also providing an implementation, which is basically incorrect to do so because that's up to the implementation to decide how to do it, not the language specification. I would actually be surprised if most implementations use recursion as you are.

No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants