AC-7098: Performance issue in TableNameSniff with big array #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated rector/rector because its dependency phpstan/phpstan released 1.9 and caused build to fail
|
New version phpstan/phpstan (1.8.9 => 1.9.2) released and caused this build to fail. In my last commit I updated rector/rector and its dependency phpstan/phpstan. Plus fixed related to this update failing tests Magento2/Rector/Tests/* |
|
Closing this PR and recreated in internal https://github.com/magento-commerce/magento-coding-standard/pull/197 |
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix summary
The performance of TableNameSniff degradated with a big array and structure like this
$fooBar=array(0=>array(125,0,875,750),1 =>array(85,0,194,716), 2 => 100);But TableNameSniff expected to process the associative array similar to
['main_table_name' => 'magento/sample_table']in result, $phpcsFile->findPrevious could not find associate array key in $stackPtr -1
The fix is to make findPrevious to find any non whitespace token as array key
Related Pull Requests
https://github.com/magento-commerce/mray/pull/158