[core] Remove benchmark package
#46007
Open
+0
−2,317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-46007--material-ui.netlify.app/ Bundle size report |
|
I'm confused as for why remove it. Isn't this folder important when we test performance changes? Put it differently, how do we assess PR changes help or harm performance? Ideally, we have vercel/next.js#74334 (comment) or mui/mui-x#17534 (review) that we can automatically run in PRs, but without this, don't we have to have a benchmark folder we can run anytime we have a doubt? At least, this is how I used to use this. Maybe the benchmark folder being outdated is simply the lagging indicator that we have a performance culture problem. |
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as mui/mui-x#9413. I also don't see it being used after the v5 release.