Skip to content

**[IMPROVEMENT]** Update dependency + auto detect ServiceProvider #5

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

repat
Copy link

@repat repat commented Sep 3, 2019

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I have added tests to prove that the code in this PR works.

Description

Couldn't install this because of your internal dependency of padosoft/support and Carbon. Updated that and AutoDiscover for the ServiceProvider.

@lopadova
Copy link
Contributor

lopadova commented Sep 3, 2019

Hi,
thanks for the pr.

Unfortunately travis says that some check ware not successful
the error is in composer.json:
you write extra": {
with one " please correct in
"extra": {
to make valid json.

See:
https://travis-ci.org/padosoft/laravel-google-structured-data-testing-tool/jobs/580107127
[Seld\JsonLint\ParsingException]
"./composer.json" does not contain valid JSON
Parse error on line 50:
...phpunit" }, extra": { "l
--------------------^
Expected: 'STRING' - It appears you have an extra trailing comma

Can you fix this?
If you fix I accept the pull request.

thanks.
Lorenzo.

@repat
Copy link
Author

repat commented Sep 3, 2019

Sry, it's 2am here 😅 Fixed.

Thanks for the quick reply

@repat
Copy link
Author

repat commented Sep 14, 2019

@lopadova bump :)

No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants