BUG: Fix na_values dict not working on index column (#57547) #57965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix base_parser not setting col_na_values when na_values is a dict containing None * fix python_parser applying na_values in a column None * add unit test to test_na_values.py; * update whatsnew.
|
@rhshadrach Would it be possible to ask someone to review this PR? Thank you |
mroeschke
approved these changes
Apr 9, 2024
|
Thanks @tomhoq |
|
Thank you for the review |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
pandas-dev#57965) BUG: Na_values dict not working on index column (pandas-dev#57547) * fix base_parser not setting col_na_values when na_values is a dict containing None * fix python_parser applying na_values in a column None * add unit test to test_na_values.py; * update whatsnew.
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.In the read_csv method, pandas allows having na_values set as a dict, which in such case lets you decide which values are null for each column. In the occurence of one of the columns being
None, no null values are applied to the column and it remains as it was. This specific case is what is being tested in the issue #57547.The problem was that in these particular conditions variables
col_na_valuesandcol_na_fvalueswere not being set correctly causing aTypeError. All i had to do was correctly define these variables as empty sets in anelseblock.On the python engine this same logic was not yet programmed. I implemented it, by adding an if statement, ensuring na_values are only applied if the column is not
None.