Skip to content

Add hotel estimates #54

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2022
Merged

Add hotel estimates #54

merged 3 commits into from
Apr 12, 2022

Conversation

boconnell2
Copy link
Contributor

What

  • Adds support for new hotel estimates endpoint

Why

  • Provides SDK coverage for new endpoint

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • If endpoints were removed, did you manually remove the corresponding files? (this should be rare)
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@@ -183,6 +183,18 @@ def test_create_ethereum_estimate_transaction_value(self):
estimate.data.mass_g, 1
) # not setting an exact value since this is changing daily

def test_create_hotel_estimate(self):
"""Test case for create_hotel_estimate
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is failing. But it's not obvious to me why. I'm getting a keyword error on the country_code arg, but it doesn't seem like that should be causing a problem since it is a required argument.

Here's a direct copy of the error message:
"Got an unexpected keyword argument 'country_code' to method create_hotel_estimate"

Anyone have an idea what the issue might be here? Is there something bespoke about the python generation process?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boconnell2 I can't check the issue right now, but my gut feeling is that this variable need to be allowed specifically for the Python SDK (one of multiple quirks). Check out this past PR: https://github.com/patch-technology/client-code-generation/pull/57/files#r847829571. I think if you do the same thing that might solve your issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This did the trick! Thank you for the tip

@boconnell2 boconnell2 requested a review from a team April 11, 2022 23:51
@boconnell2 boconnell2 requested a review from pcothenet April 12, 2022 13:14
Copy link
Contributor

@kleinjm kleinjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@boconnell2 boconnell2 merged commit 3477fc6 into main Apr 12, 2022
@boconnell2 boconnell2 deleted the boc/hotel-estimates branch April 12, 2022 13:40
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants