Skip to content

Rm/1.21.0 #59

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 4, 2022
Merged

Rm/1.21.0 #59

merged 4 commits into from
May 4, 2022

Conversation

rmody3
Copy link
Contributor

@rmody3 rmody3 commented May 4, 2022 •
edited
Loading

What

Asana: https://app.asana.com/0/1202119733323437/1202220351403228/f

Why

  • match sdk to api

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • If endpoints were removed, did you manually remove the corresponding files? (this should be rare)
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@rmody3 rmody3 requested a review from a team May 4, 2022 05:13
pcothenet
pcothenet approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@pcothenet pcothenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmody3 great work! Can you also update the README to use non-deprecated inputs?

@rmody3 rmody3 merged commit 2011c77 into main May 4, 2022
@rmody3 rmody3 deleted the rm/1.21.0 branch May 4, 2022 20:18
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@pcothenet pcothenet pcothenet approved these changes

@kleinjm kleinjm kleinjm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmody3 @pcothenet @kleinjm