Skip to content

Add accept_language support #60

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2022
Merged

Add accept_language support #60

merged 1 commit into from
May 16, 2022

Conversation

pcothenet
Copy link
Contributor

What

  • Adds support for the accept_language option

Why

  • i18n

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • If endpoints were removed, did you manually remove the corresponding files? (this should be rare)
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

@pcothenet pcothenet requested a review from a team May 16, 2022 22:56
holtbp
holtbp approved these changes May 16, 2022
View reviewed changes
patch_api/api/projects_api.py
@@ -79,6 +79,7 @@ def retrieve_project(self, id={}, **kwargs): # noqa: E501

:param async_req bool: execute request asynchronously
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the type last on this particular line? 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. This is all auto-generated and not being a python expert i'm actually not quite sure what this does.

@pcothenet pcothenet merged commit a1852fc into main May 16, 2022
@pcothenet pcothenet deleted the pc/1.22 branch May 16, 2022 23:59
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@holtbp holtbp holtbp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcothenet @holtbp