Upgrade php-amqplib #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterjus
commented
Mar 17, 2021
| @@ -68,15 +70,13 @@ public function testOnAcknowledgeShouldAcknowledgeMessage() | |||
| $channel | |||
| ->expects($this->once()) | |||
| ->method('basic_ack') | |||
| ->with(167) | |||
| ; | |||
| ->with(167); | |||
There was a problem hiding this comment.
autoformatter did this, I could change it back if necessary
|
thanks a lot. |
|
Thanks for your pull request! We love contributions. However, this repository is what we call a "subtree split": a read-only copy of one directory of the main enqueue-dev repository. It is used by Composer to allow developers to depend on specific Enqueue package. If you want to contribute, you should instead open a pull request on the main repository: https://github.com/php-enqueue/enqueue-dev Read the contribution guide https://github.com/php-enqueue/enqueue-dev/blob/master/docs/contribution.md Thank you for your contribution! |
|
It's done php-enqueue/enqueue-dev#1146 |
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday php-amqplib was upgraded to php8 with v3.0.0