Skip to content

Fix wrong exceptions in transports #637

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Fix wrong exceptions in transports #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/gearman/GearmanProducer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Interop\Queue\Destination;
use Interop\Queue\Exception\InvalidDestinationException;
use Interop\Queue\Exception\InvalidMessageException;
use Interop\Queue\Exception\PriorityNotSupportedException;
use Interop\Queue\Message;
use Interop\Queue\Producer;

Expand Down Expand Up @@ -59,7 +60,7 @@ public function setPriority(int $priority = null): Producer
return $this;
}

throw new \LogicException('Not implemented');
throw PriorityNotSupportedException::providerDoestNotSupportIt();
}

public function getPriority(): ?int
Expand Down
3 changes: 2 additions & 1 deletion pkg/pheanstalk/PheanstalkProducer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Interop\Queue\Destination;
use Interop\Queue\Exception\InvalidDestinationException;
use Interop\Queue\Exception\InvalidMessageException;
use Interop\Queue\Exception\PriorityNotSupportedException;
use Interop\Queue\Message;
use Interop\Queue\Producer;
use Pheanstalk\Pheanstalk;
Expand Down Expand Up @@ -75,7 +76,7 @@ public function setPriority(int $priority = null): Producer
return $this;
}

throw new \LogicException('Not implemented');
throw PriorityNotSupportedException::providerDoestNotSupportIt();
}

public function getPriority(): ?int
Expand Down
3 changes: 2 additions & 1 deletion pkg/rdkafka/RdKafkaProducer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Interop\Queue\Destination;
use Interop\Queue\Exception\InvalidDestinationException;
use Interop\Queue\Exception\InvalidMessageException;
use Interop\Queue\Exception\PriorityNotSupportedException;
use Interop\Queue\Message;
use Interop\Queue\Producer;
use RdKafka\Producer as VendorProducer;
Expand Down Expand Up @@ -70,7 +71,7 @@ public function setPriority(int $priority = null): Producer
return $this;
}

throw new \LogicException('Not implemented');
throw PriorityNotSupportedException::providerDoestNotSupportIt();
}

public function getPriority(): ?int
Expand Down
3 changes: 2 additions & 1 deletion pkg/redis/RedisProducer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Interop\Queue\Destination;
use Interop\Queue\Exception\InvalidDestinationException;
use Interop\Queue\Exception\InvalidMessageException;
use Interop\Queue\Exception\PriorityNotSupportedException;
use Interop\Queue\Message;
use Interop\Queue\Producer;
use Ramsey\Uuid\Uuid;
Expand Down Expand Up @@ -94,7 +95,7 @@ public function setPriority(int $priority = null): Producer
return $this;
}

throw new \LogicException('Not implemented');
throw PriorityNotSupportedException::providerDoestNotSupportIt();
}

public function getPriority(): ?int
Expand Down
3 changes: 2 additions & 1 deletion pkg/stomp/StompProducer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use Interop\Queue\Destination;
use Interop\Queue\Exception\InvalidDestinationException;
use Interop\Queue\Exception\InvalidMessageException;
use Interop\Queue\Exception\PriorityNotSupportedException;
use Interop\Queue\Message;
use Interop\Queue\Producer;
use Stomp\Client;
Expand Down Expand Up @@ -64,7 +65,7 @@ public function setPriority(int $priority = null): Producer
return $this;
}

throw new \LogicException('Not implemented');
throw PriorityNotSupportedException::providerDoestNotSupportIt();
}

public function getPriority(): ?int
Expand Down