Skip to content

Update Cargo.toml dependency versions to match Cargo.lock #1

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Cargo.toml dependency versions to match Cargo.lock #1

wants to merge 1 commit into from

Conversation

polybuildr
Copy link
Owner

See rust-lang#57443 for more context.

@polybuildr
Copy link
Owner Author

Decided to create a sample PR to demo what changes get made.

@polybuildr
Copy link
Owner Author

Attempt 1 issues include:

  • Comments getting removed: package = "1.0" # some comment becomes package = "1.2"
  • The ignoring of patch version works fine for "X.Y", but for "X" it replaces the whole thing including the patch version. (Logical error, easy to fix.)
  • Auto-formats inline tables - possibly not a bad thing?

@polybuildr
Copy link
Owner Author

  • Some random reordering of sections... specifically package.metadata.fortanix-sgx in libstd/Cargo.toml (bug in toml_edit?)

@polybuildr polybuildr mentioned this pull request May 5, 2019
Open
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@polybuildr