Skip to content

feat(dom-to-react): pass index as 2nd argument to replace option #1260

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

remarkablemark
Copy link
Owner

What is the motivation for this pull request?

feat(dom-to-react): pass index as 2nd argument to replace option

Closes #1240

What is the current behavior?

replace option has 1 argument: domNode

What is the new behavior?

replace option has 2 arguments: domNode and index

Checklist:

@remarkablemark remarkablemark added the feature New feature or request label Jan 10, 2024
@remarkablemark remarkablemark self-assigned this Jan 10, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e94b15) 100.00% compared to head (b27d30c) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1260   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          151       151           
  Branches        49        49           
=========================================
  Hits           151       151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 9.18 KB (-0.08% 🔽) 184 ms (-0.08% 🔽) 9 ms (+12.18% 🔺) 193 ms

@remarkablemark remarkablemark merged commit a706ced into master Jan 10, 2024
@remarkablemark remarkablemark deleted the feat/replace branch January 10, 2024 20:54
@remarkablemark
Copy link
Owner Author

No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Current Node Index in replace Callback
1 participant