Skip to content

Diag migrate #100871

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Diag migrate #100871

wants to merge 18 commits into from

Conversation

AndyJado
Copy link
Contributor

@rustbot label +A-translation

r? rust-lang/diagnostics


region_errors.rs passes on my local

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 22, 2022
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2022
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    Checking rustc_mir_transform v0.0.0 (/checkout/compiler/rustc_mir_transform)
error[E0432]: unresolved import `crate::session_diagnostics::RequireStaticErr`
  --> compiler/rustc_borrowck/src/diagnostics/region_errors.rs:30:32
   |
30 |     LifeTimeReturnCategoryErr, RequireStaticErr,
   |                                ^^^^^^^^^^^^^^^^ no `RequireStaticErr` in `session_diagnostics`
error[E0308]: mismatched types
   --> compiler/rustc_borrowck/src/diagnostics/region_errors.rs:685:67
    |
    |
685 |         let mut err = LifeTimeOutLiveErr { span: *span, category: None };
    |                                                                   ^^^^ expected enum `LifeTimeReturnCategoryErr`, found enum `Option`
    |
    = note: expected enum `LifeTimeReturnCategoryErr`

error[E0308]: mismatched types
   --> compiler/rustc_borrowck/src/diagnostics/region_errors.rs:705:24
    |
    |
705 |         err.category = Some(err_category);
    |         ------------   ^^^^^^^^^^^^^^^^^^ expected enum `LifeTimeReturnCategoryErr`, found enum `Option`
    |         expected due to the type of this binding
    |
    |
    = note: expected enum `LifeTimeReturnCategoryErr`
               found enum `Option<LifeTimeReturnCategoryErr>`
Some errors have detailed explanations: E0308, E0432.
For more information about an error, try `rustc --explain E0308`.
error: could not compile `rustc_borrowck` due to 3 previous errors
warning: build failed, waiting for other jobs to finish...

@AndyJado AndyJado closed this Aug 23, 2022
@AndyJado AndyJado deleted the diag-migrate branch August 23, 2022 03:46
@davidtwco davidtwco mentioned this pull request Nov 8, 2022
84 tasks
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants