Revert "Do not lift annotation arguments" from 3.3 LTS #23062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbovel
approved these changes
Apr 28, 2025
This reverts commit a08bf03.
tgodzik
force-pushed
the
revert-annot-changes
branch
from
8f85afc to
3a2946e
Compare
tgodzik
changed the title
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we cannot backport #22553 and it wouldn't make sense to only backport this single change to annotations.
We'll do 3.3.6-RC2 and move the release until the next week.
This reverts both #22035 and #22046