InteractiveSetup breaks when it encounters a space within values #1332
+89
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jamesalbert Thank you! |
|
Hey @fiftin sounds good! |
|
Hi @jamesalbert could you merge |
|
hey @fiftin (long time to talk to! 😅 ), I didn't have the option to merge develop again, but I triggered the action by adding a clearer comment in askValue. |
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue when I deployed with my ldap credentials. My SEMAPHORE_LDAP_DN_BIND has a space in it. fmt.Scan stops at spaces, so the values got cut up and distributed incorrectly. The change proposed creates a single reader for all cases of ingesting user input (instead of a half mix of bufio.Reader and fmt.Scan).
Compilation and tests pass on my end. I also provided my config with the spaces in it and works.