-
Notifications
You must be signed in to change notification settings - Fork 631
Set TPU VM the default option #1758
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Conversation
This PR is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
@infwinston Any updates? |
We need someone to take over this PR to get it in. This is requested by our user. |
Tested(88562fe):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Michaelvll @infwinston. Quick question.
sky/backends/cloud_vm_ray_backend.py
Outdated
if version < 7: | ||
launched_resources = state['launched_resources'] | ||
|
||
# Backward compatibility: we change the default value for TPU VM to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QQ: why handle here vs. in
Line 47 in 88562fe
_VERSION = 13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Moved it to resources instead. : )
Thanks @concretevitamin for the review! Updated the docs. PTAL |
Tested:
resources:
accelerators: tpu-v2-8
run: |
echo "Hello World"
|
This PR changes the default for TPU from TPU node to TPU VM as the former is now being deprecated by GCP.
for example, the tpu-v4 arch doesn't support TPU node (ref)
Tested (run the relevant ones):
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh