Skip to content

UX: if a cluster becomes INIT, warn about autostop reset. #2085

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

concretevitamin
Copy link
Member

User reported that it's confusing an newly-INIT (abnormal) cluster suddenly had its autostop canceled.

This PR adds a warning when that happens.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
sky launch -c dbg -i10
# ssh into dbg and `ray stop`
sky status -r  # Observed warning.
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this hint @concretevitamin! Left two nits.

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@concretevitamin concretevitamin merged commit 0abff5e into master Jun 15, 2023
@concretevitamin concretevitamin deleted the autostop-ux branch June 15, 2023 16:27
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants