Skip to content

[UX] Make retry clean up security group silent #2728

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Oct 22, 2023

There will be some output that interrupts the progress bar when clean-up SG fails:

» sky down sky-serve-controller-8a3968f2-0
Tearing down sky serve controller: sky-serve-controller-8a3968f2-0.
To proceed, please check the information above and type 'delete': delete
Terminating 1 cluster ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━   0% -:--:--I 10-19 21:52:21 instance.py:697] Security group sky-sg-sky-serve-controller-8a3968f2-0-8a39 is still in use. Retry.
Terminating cluster sky-serve-controller-8a3968f2-0...done.
Terminating 1 cluster ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 100% 0:00:00

This PR makes the log silent by changing it to debug. See #2458 (review) for more information.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@cblmemo cblmemo mentioned this pull request Oct 22, 2023
5 tasks
Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cblmemo.

@cblmemo cblmemo merged commit 16e913a into master Oct 23, 2023
@cblmemo cblmemo deleted the silent-retry-logs-in-port branch October 23, 2023 06:04
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants