[Examples] vLLM example for SkyServe + Mixtral #2948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Michaelvll
reviewed
Jan 8, 2024
llm/vllm/README.md
Outdated
| @@ -126,3 +126,61 @@ curl http://$IP:8000/v1/chat/completions \ | |||
| } | |||
| } | |||
| ``` | |||
|
|
|||
| ## Serving Mixtral 8x7b model with vLLM and SkyServe | |||
There was a problem hiding this comment.
We already have the mixtral 8x7b + vLLM and SkyServe in llm/mixtral. Should we just make the example above to be launchable with sky serve and have an additional link refering to the llm/mixtral?
There was a problem hiding this comment.
Make sense! Changed. PTAL again 🫡
Michaelvll
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Thanks for updating the example @cblmemo! Left several comments.
llm/vllm/service.yaml
Outdated
| HF_TOKEN: <your-huggingface-token> # Change to your own huggingface token | ||
|
|
||
| resources: | ||
| accelerators: L4:1 |
There was a problem hiding this comment.
Let's use multiple accelerators for this and the original yaml files, so that a user without GCP credentials can use the yaml out-of-the-box, e.g.,{L4:1, A10G:1, A10:1, A100:1, A100-80GB:1}
Co-authored-by: Zhanghao Wu <zhanghao.wu@outlook.com>
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added example in #2922 to
llm/vllm.Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh