Skip to content

[AWS] Add security_group_name back #3133

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 2 commits into from
Feb 9, 2024
Merged

[AWS] Add security_group_name back #3133

merged 2 commits into from
Feb 9, 2024

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Feb 9, 2024

The security_group_name feature was accidentally removed when we added the schema check for ~/.sky/schemas.py. This PR is to add it back and fixes user requests in #1354.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • sky launch -c test-aws --cloud aws --cpus 2 with the following config yaml:
aws:
  security_group_name: launch-wizard-7
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll Michaelvll merged commit 221f347 into master Feb 9, 2024
@Michaelvll Michaelvll deleted the security-group branch February 9, 2024 17:38
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support advanced AWS feature
2 participants