-
Notifications
You must be signed in to change notification settings - Fork 631
[k8s][docs] K3s docs and runtime auto-detection #3148
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome @romilbhardwaj! Left some nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix @romilbhardwaj! LGTM.
Thanks @Michaelvll! I've refactored and tested the gpu_labeller on k3s and EKS. I've also added a |
Closes #3034 and #2958. Adds docs and automatic runtimeclass detection for k3s users.
Tested (run the relevant ones):
bash format.sh
sky launch
on a manually setup k3s clustersky launch
on GKE cluster