Skip to content

[k8s][docs] K3s docs and runtime auto-detection #3148

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 6 commits into from
Feb 14, 2024

Conversation

romilbhardwaj
Copy link
Collaborator

@romilbhardwaj romilbhardwaj commented Feb 12, 2024

Closes #3034 and #2958. Adds docs and automatic runtimeclass detection for k3s users.

Tested (run the relevant ones):

  • Docs rendered locally
  • Code formatting: bash format.sh
  • Tested GPU labelling script and sky launch on a manually setup k3s cluster
  • Tested sky launch on GKE cluster
  • Kubernetes smoke tests using T4.

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @romilbhardwaj! Left some nits.

Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @romilbhardwaj! LGTM.

@romilbhardwaj
Copy link
Collaborator Author

Thanks @Michaelvll! I've refactored and tested the gpu_labeller on k3s and EKS.

I've also added a deploy_k3s.sh for our debugging purposes to easily deploy a k3s cluster for testing.

@romilbhardwaj romilbhardwaj merged commit fe14520 into master Feb 14, 2024
@romilbhardwaj romilbhardwaj deleted the k3s_docs_autodetect branch February 14, 2024 06:01
@romilbhardwaj romilbhardwaj mentioned this pull request Feb 28, 2024
1 task
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[k8s] K3s support - auto add Nvidia runtime class if present on cluster, update docs
2 participants