-
Notifications
You must be signed in to change notification settings - Fork 631
[Jobs] --sync-down execution log support for managed jobs #4527
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KeplerC! Left several comments below : )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KeplerC! Left several comments : ) Also, we should add a smoke test for the newly added functionality
…b status. This update improves the reliability of the test by ensuring the job is in a RUNNING state before proceeding with log synchronization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good now, left some relatively minor comments.
Also, please address the lint failures!
Co-authored-by: Christopher Cooper <christopher@cg505.com>
- Changed the method name from `get_job_ids_by_name` to `get_all_job_ids_by_name` for clarity in `ManagedJobCodeGen`. - Updated the CLI option flag for `sync-down` from `-d` to `-s` for better alignment with common conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the changes, looks good to me!
This aims to resolve #4056 for managed jobs, we should have a flag --sync-down that download the logs to local machine.
Tested (run the relevant ones):
bash format.sh