[k8s] Fix GPU detection when running with sky local up --ips
#4561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
approved these changes
Jan 15, 2025
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
sky local up --ipsis run on a remote cluster with CPUs only, our script incorrectly detects GPUs and gets stuck at installing nvidia GPU operator. This is because the check_gpu function is silently failing but the output is still being interpreted as truthy. This PR fixes it by explicitly returning true/false values.Tested (run the relevant ones):
bash format.shsky local up --ips ips.txt --ssh-user ubuntu --ssh-key-path ~/.sky/generated/ssh-keys/aws.keyon a CPU only cluster.