[k8s] [config] merge initContainers by name #5247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the same
initContainers
field is specified on both client and server, the merged initContainers field ends up containing duplicate values and job launch would fail.We actually already have a logic for dealing with list merges with a mergekey of
name
- so I just use that.I am starting to have a bigger question of how much longer we want to be maintaining this custom merge logic for kubernetes, but for now, this works and will solve some immediate user pains.
Tested (run the relevant ones):
bash format.sh
initContainers
on both client and server and verify no duplicate is created after config merge.