fix:toolcall return string #2885
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cui-xf <cui_xf293@qq.com>
markpollack
reviewed
Apr 29, 2025
| @@ -58,6 +58,10 @@ public String convert(@Nullable Object result, @Nullable Type returnType) { | |||
| final var imgB64 = Base64.getEncoder().encodeToString(buf.toByteArray()); | |||
| return JsonParser.toJson(Map.of("mimeType", "image/png", "data", imgB64)); | |||
| } | |||
| else if (result instanceof String stringResult) { | |||
There was a problem hiding this comment.
the current assumption is that if is not a rendered image, we assume it is json (also a string) in this current PR, the json conversion in the else statement will never be accessed. Can you explain more of the surrounding use case that motivated you to make this change? adding to DefaultToolCallResultConverterTests?
There was a problem hiding this comment.
Also wondering why JsonParser.toJson(result); doesn't use Type returnType
No Sign up for free
to join this conversation on GitHub.
Already have an account?
No Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cui-xf cui_xf293@qq.com
Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:
mainbranch and squash your commits