Skip to content

Consider adding jackson-datatype-jsr310 to Web starter #9297

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Closed
vpavic opened this issue May 24, 2017 · 5 comments
Closed

Consider adding jackson-datatype-jsr310 to Web starter #9297

vpavic opened this issue May 24, 2017 · 5 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@vpavic
Copy link
Contributor

vpavic commented May 24, 2017

In a similar fashion like #9229, it would be nice if Web starter would pull in jackson-datatype-jsr310 module.

In addition, perhaps a case could be made for other modules that are a part of jackson-modules-java8.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 24, 2017
@philwebb philwebb added for: team-attention An issue we'd like other members of the team to review priority: normal type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged for: team-attention An issue we'd like other members of the team to review labels May 24, 2017
@philwebb philwebb added this to the 2.0.0.M2 milestone May 25, 2017
@snicoll
Copy link
Member

snicoll commented May 29, 2017

There are more than one starter where Jackson is provided. I guess spring-boot-starter-jackson is a bit weird, the alternative is that we should include in the data-rest and webflux starters (perhaps jersey as well?).

A dedicated starter would make #400 much easier to implement in a customization though.

@snicoll snicoll added the for: team-attention An issue we'd like other members of the team to review label May 29, 2017
@philwebb
Copy link
Member

I think a starter makes sense, we don't want to duplicate the same dependencies all over the shop Perhaps we should call it something more general like spring-boot-starter-json?

@snicoll
Copy link
Member

snicoll commented Jun 2, 2017

dedicated starter would make #400 much easier to implement in a customization though.

I take it back. This would be a transitive dependency of a starter chosen on the initializr so that wouldn't change anything.

@snicoll snicoll closed this as completed in a00ad72 Jun 2, 2017
@snicoll snicoll self-assigned this Jun 2, 2017
@snicoll snicoll removed the for: team-attention An issue we'd like other members of the team to review label Jun 2, 2017
@snicoll
Copy link
Member

snicoll commented Jun 2, 2017

That change breaks the glassfish integration test. Looks like Glassfish 4.1 provides Jackson 2.5

@snicoll snicoll reopened this Jun 2, 2017
snicoll added a commit that referenced this issue Jun 2, 2017
This dependency breaks Glassfish integration tests and was not strictly
required by #9297.
@snicoll
Copy link
Member

snicoll commented Jun 2, 2017

Follow-up on that issue on #9391

@snicoll snicoll closed this as completed Jun 2, 2017
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants