-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
chore: use pkg.imports for builder.js #15785
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Conversation
|
|
Actually it looks like the playground already works, because it's using the bundled compiler |
We should double check that (our) rollup and webpack (plugins) work with it but otherwise I see no reason not to do this |
Confirmed it works with both rollup and webpack |
I'll take #15785 (comment) as a verbal approval and merge this so that it doesn't become a merge conflict magnet. Once we've established that the release works as expected we can apply the same treatment to other common modules. This will clean up a bunch of stuff |
Occurs to me that for modules that are used throughout the codebase, like
builders.js
, we could usepkg.imports
and save ourselves a lot of../../../
Might need to update the resolution logic in the playground but we ought to do that anyway. Can anyone think of a reason not to do this?