Skip to content

chore: use pkg.imports for builder.js #15785

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025
Merged

chore: use pkg.imports for builder.js #15785

merged 3 commits into from
Apr 17, 2025

Conversation

Rich-Harris
Copy link
Member

Occurs to me that for modules that are used throughout the codebase, like builders.js, we could use pkg.imports and save ourselves a lot of ../../../

Might need to update the resolution logic in the playground but we ought to do that anyway. Can anyone think of a reason not to do this?

Copy link

changeset-bot bot commented Apr 17, 2025

⚠️ No Changeset found

Latest commit: c192585

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15785

@Rich-Harris
Copy link
Member Author

Actually it looks like the playground already works, because it's using the bundled compiler

@svelte-docs-bot
Copy link

@dummdidumm
Copy link
Member

We should double check that (our) rollup and webpack (plugins) work with it but otherwise I see no reason not to do this

@Rich-Harris
Copy link
Member Author

Confirmed it works with both rollup and webpack

@Rich-Harris
Copy link
Member Author

I'll take #15785 (comment) as a verbal approval and merge this so that it doesn't become a merge conflict magnet. Once we've established that the release works as expected we can apply the same treatment to other common modules. This will clean up a bunch of stuff

@Rich-Harris Rich-Harris merged commit 4f8708a into main Apr 17, 2025
13 checks passed
@Rich-Harris Rich-Harris deleted the pkg-imports branch April 17, 2025 18:19
Rich-Harris added a commit that referenced this pull request Apr 17, 2025
Rich-Harris added a commit that referenced this pull request Apr 17, 2025
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants