Skip to content

Set compiler vendor name as SwiftWasm #1921

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2020
Merged

Set compiler vendor name as SwiftWasm #1921

merged 1 commit into from
Oct 6, 2020

Conversation

yonihemi
Copy link
Member

@yonihemi yonihemi commented Oct 5, 2020

Resolves #1907

@MaxDesiatov MaxDesiatov added the continuous integration Improvements to continuous integration label Oct 5, 2020
MaxDesiatov
MaxDesiatov approved these changes Oct 5, 2020
View reviewed changes
Copy link

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 👍

kateinoigakukun
kateinoigakukun approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@kateinoigakukun kateinoigakukun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

$ $HOME/Downloads/swift-wasm-DEVELOPMENT-SNAPSHOT-2020-10-05-a/usr/bin/swift --version
SwiftWasm Swift version 5.3-dev (LLVM 17f3ed423dd0489, Swift 13ca13b1f1d50b7)
Target: x86_64-apple-darwin19.6.0

@kateinoigakukun kateinoigakukun merged commit f04b4cb into swiftwasm:swiftwasm Oct 6, 2020
@yonihemi yonihemi deleted the vendor_name branch October 6, 2020 01:56
This was referenced Oct 21, 2020
Merged
Merged
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@kateinoigakukun kateinoigakukun kateinoigakukun approved these changes

Assignees
No one assigned
Labels
continuous integration Improvements to continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set vendor name for --version command
3 participants
@yonihemi @MaxDesiatov @kateinoigakukun