Skip to content

Update openEuler dockerfile for COMPILE_CUSTOM_KERNELS=1 #664

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

wxsIcey
Copy link
Contributor

@wxsIcey wxsIcey commented Apr 26, 2025

What this PR does / why we need it?

Update openEuler dockerfile for COMPILE_CUSTOM_KERNELS=1

Does this PR introduce any user-facing change?

None

How was this patch tested?

@wxsIcey wxsIcey force-pushed the wxs_0426 branch 3 times, most recently from b42c5fe to 351314f Compare April 26, 2025 15:57
Copy link
Collaborator

@Yikun Yikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And for main pls refer to #661

Especially, pip cache purge and $LD_LIBRARY_PATH order and layer squash

wxsIcey added 4 commits April 27, 2025 01:41
Signed-off-by: Icey <1790571317@qq.com>
Signed-off-by: Icey <1790571317@qq.com>
Signed-off-by: Icey <1790571317@qq.com>
Signed-off-by: Icey <1790571317@qq.com>
@@ -96,4 +96,4 @@ jobs:
# TODO: support and enable custom ops build for openEuler
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this todo can be removed.


# Install vllm-ascend
RUN source /usr/local/Ascend/ascend-toolkit/set_env.sh && \
source /usr/local/Ascend/nnal/atb/set_env.sh && \
export LD_LIBRARY_PATH=/usr/local/Ascend/ascend-toolkit/latest/`uname -i`-linux/devlib:$LD_LIBRARY_PATH && \
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/local/Ascend/ascend-toolkit/latest/`uname -i`-linux/devlib && \
export LIBRARY_PATH=/usr/local/Ascend/ascend-toolkit/latest/lib64:$LIBRARY_PATH && \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LIBRARY_PATH can be removed IMO

Yikun and others added 7 commits April 28, 2025 01:33
### What this PR does / why we need it?
vLLM Ascend side followup on:
[Core] Remove prompt string from engine core data structures

vllm-project/vllm@df6f3ce

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI passed

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
### What this PR does / why we need it?
This pr support minicpm in branch main. see
vllm-project#164


### How was this patch tested?
test locally with minicpm

---------

Signed-off-by: MengqingCao <cmq0113@163.com>
…ct#656)

### What this PR does / why we need it?
Eliminated duplicate `block_table` tensor initialization and cleaned up
unused code segments. This resolves an issue where the second creation
was overwriting the first, potentially leading to unexpected behavior.

Signed-off-by: Jade Zheng <zheng.shoujian@outlook.com>
The torch-npu 2.5.1 are published:
https://pypi.org/project/torch-npu/2.5.1/
It's time to remove all torch-npu dev version from vllm-ascend code base

Yes, using torch-npu 2.5.1

- [ ] CI passed
- [ ] Manually test
- [ ] Grep all `dev2025`

---------

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
)

### What this PR does / why we need it?
Fix pip install cmd in installation.md

Followup on: vllm-project#661

### Does this PR introduce _any_ user-facing change?
No, doc only

### How was this patch tested?
Preview

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
### What this PR does / why we need it?
`reshape_and_cache_siso` seems have some funcitonality issues, use torch
op combination replace this custom op by default.


---------

Signed-off-by: ganyi <pleaplusone.gy@gmail.com>
Signed-off-by: Icey <1790571317@qq.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 28, 2025
@wxsIcey wxsIcey closed this Apr 28, 2025
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants