Skip to content

[Misc] Qwen2.5 VL support LoRA #13261

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 20, 2025
Merged

[Misc] Qwen2.5 VL support LoRA #13261

merged 8 commits into from
Feb 20, 2025

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Feb 14, 2025 •
edited by github-actions bot
Loading

No description provided.

@jeejeelee
DOne
3d943b5 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Feb 14, 2025
@DarkLight1337
Copy link
Member

Is there a HF repo that can be used to test this?

@jeejeelee
Copy link
Collaborator Author

Is there a HF repo that can be used to test this?

Not yet, if needed, I can train and add tests

@DarkLight1337
Copy link
Member

@imkero @wulipc do you have any LoRA-tuned models that can be used? cc @ywang96

@imkero
Copy link
Contributor

imkero commented Feb 14, 2025

@imkero @wulipc do you have any LoRA-tuned models that can be used? cc @ywang96

Sorry I don't have one currently

@ywang96
Copy link
Member

ywang96 commented Feb 14, 2025 •
edited
Loading

@imkero @wulipc do you have any LoRA-tuned models that can be used? cc @ywang96

Sorry I don't have one currently

It would be great if we can test LoRA but I'm also somewhat okay with shipping this PR as is since LoRA support itself is model agnostic IMO.

@jeejeelee
Copy link
Collaborator Author

@imkero @wulipc do you have any LoRA-tuned models that can be used? cc @ywang96

Sorry I don't have one currently

It would be great if we can test LoRA but I'm also somewhat okay with shipping this PR as is since LoRA support itself is model agnostic IMO.

I am glad to add this test ,and will handling asap

@jeejeelee
Merge branch 'vllm-project:main' into qwen25vl_lora
5559215
@jeejeelee
Add unit test
7758f8c 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee
Copy link
Collaborator Author

@DarkLight1337 @ywang96 I have added the LoRA test

@jeejeelee
Fix
43faa41 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee
Fix
711259e 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee
Fix format
f2a6689 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee
Merge branch 'vllm-project:main' into qwen25vl_lora
cf17716
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 19, 2025 12:21
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 19, 2025
@jeejeelee
verify lora test
e0ff1f2 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee
Copy link
Collaborator Author

@DarkLight1337 It looks like we need force merge

@simon-mo simon-mo merged commit 512368e into vllm-project:main Feb 20, 2025
46 of 50 checks passed
@jeejeelee jeejeelee deleted the qwen25vl_lora branch February 20, 2025 02:53
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
@jeejeelee
[Misc] Qwen2.5 VL support LoRA (vllm-project#13261)
67f2db2
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@jeejeelee @Akshat-Tripathi
[Misc] Qwen2.5 VL support LoRA (vllm-project#13261)
3f8fdc1
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@jeejeelee @lulmer
[Misc] Qwen2.5 VL support LoRA (vllm-project#13261)
cdf21ec 
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeejeelee @DarkLight1337 @imkero @ywang96 @simon-mo