-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
docs: Add a note on full CI run in contributing guide #13646
New issue
Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? No Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
08e0572
to
40cdc4e
Compare
I think this is unnecessary since it's also mentioned by the bot. |
Oh thanks for pointing that out. I did not notice it. However, I think this is still nice to have this is the doc contributors would read even before submitting the PR. It's also in the spirit of making the process transparent as claimed in the doc:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
…3646) Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
This is based on my observation through the past PRs. Feel free to correct if I have missed anything or misunderstood the process.