Skip to content

[Misc] Deprecate --dataset from benchmark_serving.py #13708

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

No Sign up for GitHub

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 23, 2025
Merged

[Misc] Deprecate --dataset from benchmark_serving.py #13708

merged 2 commits into from
Feb 23, 2025

Conversation

ywang96
Copy link
Member

@ywang96 ywang96 commented Feb 22, 2025

It's been a few releases since we gave the warning that we're going to deprecate this arg for running serving benchmark. This PR cleans it up.

cleanup
b0f0a13 
Signed-off-by: Roger Wang <ywang@roblox.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@ywang96 ywang96 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 23, 2025
@ywang96 ywang96 enabled auto-merge (squash) February 23, 2025 02:26
jeejeelee
jeejeelee approved these changes Feb 23, 2025
View reviewed changes
Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there might be some documentation that needs to be updated

@ywang96 ywang96 merged commit 9bebc95 into vllm-project:main Feb 23, 2025
40 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@ywang96 @Akshat-Tripathi
[Misc] Deprecate --dataset from benchmark_serving.py (vllm-projec…
1d8bcf7 
…t#13708)

Signed-off-by: Roger Wang <ywang@roblox.com>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@ywang96 @lulmer
[Misc] Deprecate --dataset from benchmark_serving.py (vllm-projec…
f3ad866 
…t#13708)

Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Reviewers

@comaniac comaniac comaniac approved these changes

@jeejeelee jeejeelee jeejeelee approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ywang96 @comaniac @jeejeelee