Skip to content

[Bugfix] Support MLA for CompressedTensorsWNA16 #13725

New issue

Have a question about this project? No Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “No Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? No Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Feb 23, 2025

Without this change, models that use CompressedTensorsWNA16 will fail with MLA enabled due to their usage of weight_packed

Reference:

Error:

[rank0]:   File "/home/mgoin/code/vllm/vllm/attention/backends/mla/common.py", line 1155, in process_weights_after_loading
[rank0]:     weight_dtype = get_layer_weight(self.kv_b_proj).dtype
[rank0]:                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[rank0]:   File "/home/mgoin/code/vllm/vllm/attention/backends/mla/common.py", line 1138, in get_layer_weight
[rank0]:     raise AttributeError(
[rank0]: AttributeError: Layer 'ColumnParallelLinear(in_features=512, output_features=4096, bias=False, tp_size=1, gather_output=False)' has neither weight nor qweight

Signed-off-by: mgoin <mgoin64@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: mgoin <mgoin64@gmail.com>
@mgoin mgoin added bug Something isn't working quantization labels Feb 24, 2025
@mgoin mgoin changed the title Fix MLA for CompressedTensorsWNA16 [Bugfix] Support MLA for CompressedTensorsWNA16 Feb 24, 2025
@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 24, 2025
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) February 24, 2025 18:45
@tlrmchlsmth tlrmchlsmth merged commit 18e5059 into vllm-project:main Feb 25, 2025
60 of 62 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
No Sign up for free to join this conversation on GitHub. Already have an account? No Sign in to comment
Labels
bug Something isn't working quantization ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants